Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B4218200C47 for ; Thu, 30 Mar 2017 10:45:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B28ED160B8B; Thu, 30 Mar 2017 08:45:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0425C160B78 for ; Thu, 30 Mar 2017 10:45:45 +0200 (CEST) Received: (qmail 26402 invoked by uid 500); 30 Mar 2017 08:45:45 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 26380 invoked by uid 99); 30 Mar 2017 08:45:44 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Mar 2017 08:45:44 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C5424DFE34; Thu, 30 Mar 2017 08:45:44 +0000 (UTC) From: shazron To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org Message-ID: Subject: [GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into... Content-Type: text/plain Date: Thu, 30 Mar 2017 08:45:44 +0000 (UTC) archived-at: Thu, 30 Mar 2017 08:45:46 -0000 GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/534 CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project ### Platforms affected iOS ### What does this PR do? Support the "embed" attribute for the `` tag of plugin.xml to facilitate installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for the iOS platform ### What testing has been done on this change? Added unit tests to `cordova-lib\spec-plugman\platforms\ios,spec.js` ### Other notes The same code and tests will be added to the Platform API of cordova-ios as appropriate. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-XXXX" - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-11233 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/534.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #534 ---- ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org