Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 17B4D200C3D for ; Tue, 14 Mar 2017 23:19:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1656C160B7E; Tue, 14 Mar 2017 22:19:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 601E0160B63 for ; Tue, 14 Mar 2017 23:19:56 +0100 (CET) Received: (qmail 18296 invoked by uid 500); 14 Mar 2017 22:19:55 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 18282 invoked by uid 99); 14 Mar 2017 22:19:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Mar 2017 22:19:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 23A2EDFBC9; Tue, 14 Mar 2017 22:19:55 +0000 (UTC) From: shazron To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org Message-ID: Subject: [GitHub] cordova-ios pull request #296: CB-12571 - Podfile gets overwritten and some ... Content-Type: text/plain Date: Tue, 14 Mar 2017 22:19:55 +0000 (UTC) archived-at: Tue, 14 Mar 2017 22:19:57 -0000 GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/296 CB-12571 - Podfile gets overwritten and some dependencies disappear. ### Platforms affected self ### What does this PR do? Fix adding of pods with non-alphanumeric characters in the name to Podfile ### What testing has been done on this change? Added unit tests ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-12571 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/296.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #296 ---- commit 514b3f1917a8079e3e24f0b2a4163478b437b309 Author: Shazron Abdullah Date: 2017-03-14T22:17:09Z CB-12571 - Podfile gets overwritten and some dependencies disappear. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org