Return-Path: <dev-return-67176-archive-asf-public=cust-asf.ponee.io@cordova.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id EEE29200C57
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Sat,  1 Apr 2017 01:14:56 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id ED497160B9C; Fri, 31 Mar 2017 23:14:56 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 409DD160B80
	for <archive-asf-public@cust-asf.ponee.io>; Sat,  1 Apr 2017 01:14:56 +0200 (CEST)
Received: (qmail 70115 invoked by uid 500); 31 Mar 2017 23:14:55 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 70093 invoked by uid 99); 31 Mar 2017 23:14:55 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Mar 2017 23:14:55 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 07E12DFE59; Fri, 31 Mar 2017 23:14:55 +0000 (UTC)
From: shazron <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-535-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-535-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request #535: CB-11233 - Support installing frameworks into...
Content-Type: text/plain
Message-Id: <20170331231455.07E12DFE59@git1-us-west.apache.org>
Date: Fri, 31 Mar 2017 23:14:55 +0000 (UTC)
archived-at: Fri, 31 Mar 2017 23:14:57 -0000

GitHub user shazron reopened a pull request:

    https://github.com/apache/cordova-lib/pull/535

    CB-11233 - Support installing frameworks into 'Embedded Binaries' section of the Xcode project

    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    Support the "embed" attribute for the `<framework>` tag of plugin.xml to facilitate installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for the iOS platform
    
    ### What testing has been done on this change?
    
    Unit tests are in the iOS platform, through the Platform API, see: https://github.com/apache/cordova-ios/pull/299
    
    ### Checklist
    
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [X] Commit message follows the format: "CB-XXXX"
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-lib CB-11233-b

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #535
    
----
commit d77dfa807b00770e33281a3207bd6a250b0d9ab3
Author: Shazron Abdullah <shazron@gmail.com>
Date:   2017-03-31T18:59:10Z

    CB-11233 - Support installing frameworks into 'Embedded Binaries' section of the Xcode project

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org