Return-Path: <dev-return-66841-archive-asf-public=cust-asf.ponee.io@cordova.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 07BF5200C39
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 16 Mar 2017 16:45:06 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 063D7160B7A; Thu, 16 Mar 2017 15:45:06 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 504A2160B78
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 16 Mar 2017 16:45:05 +0100 (CET)
Received: (qmail 43657 invoked by uid 500); 16 Mar 2017 15:44:59 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 43645 invoked by uid 99); 16 Mar 2017 15:44:59 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Mar 2017 15:44:59 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id DAB8CDFE8F; Thu, 16 Mar 2017 15:44:58 +0000 (UTC)
From: patrickbussmann <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-86-cordova-plugin-geolocation@git.apache.org>
In-Reply-To: <git-pr-86-cordova-plugin-geolocation@git.apache.org>
Subject: [GitHub] cordova-plugin-geolocation issue #86: Add required=false to the uses-feature
Content-Type: text/plain
Message-Id: <20170316154458.DAB8CDFE8F@git1-us-west.apache.org>
Date: Thu, 16 Mar 2017 15:44:58 +0000 (UTC)
archived-at: Thu, 16 Mar 2017 15:45:06 -0000

Github user patrickbussmann commented on the issue:

    https://github.com/apache/cordova-plugin-geolocation/pull/86
  
    You can add this line to your `config.xml`.
    
        <hook type="before_compile" src="hooks/before_compile/change_required_features_to_optional.js" />
    
    With this content.
    
      #!/usr/bin/env node
      
      module.exports = function (context) {
        var
          Q = context.requireCordovaModule('q'),
          deferral = new Q.defer(),
          fs = context.requireCordovaModule('fs'),
          path = context.requireCordovaModule('path'),
          platformRoot = path.join(context.opts.projectRoot, 'platforms/android'),
          manifestFile = path.join(platformRoot, 'AndroidManifest.xml')
        ;
      
        if (fs.existsSync(manifestFile)) {
          fs.readFile(manifestFile, 'utf8', function (err, data) {
            if (err) {
              deferral.resolve();
              throw new Error('Unable to find AndroidManifest.xml: ' + err);
            }
      
            fs.writeFile(manifestFile, (function (str) {
              str = str.replace(/android:required="true"/ig, 'android:required="false"');
              str = str.replace(/<uses-feature android:name="([^"]+)" ?\/>/ig, '<uses-feature android:name="$1" android:required="false" />');
              return str;
            })(data), 'utf8', function (err) {
              deferral.resolve();
              if (err) throw new Error('Unable to write into AndroidManifest.xml: ' + err);
            });
          });
        } else {
          deferral.resolve();
        }
      
        return deferral.promise;
      };
    
    Then it will work fine and you will have no more dependencies :+1: 
    
    But yes your pull request should be merged as soon as possible :+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org