cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brodybits <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #528: CB-12572: (windows) pin cordova-windows 5.0.0
Date Wed, 15 Mar 2017 22:23:11 GMT
GitHub user brodybits opened a pull request:

    https://github.com/apache/cordova-lib/pull/528

    CB-12572: (windows) pin cordova-windows 5.0.0

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    Windows
    
    ### What does this PR do?
    
    [CB-12572](https://issues.apache.org/jira/browse/CB-12572): use cordova-windows 5.0.0
    
    This is needed to support Windows plugin WinMD+DLL combinations ([CB-12189](https://issues.apache.org/jira/browse/CB-12189)).
    
    ### What testing has been done on this change?
    
    - Install cordova-lib with this change in a local checkout of cordova-cli
    - Do npm install of the local cordova-cli in a test directory
    - Use the local cordova-cli to add the Windows platform to a local checkout of <https://github.com/brodybits/cordova-dialogs-bootstrap-test>
    - do `cordova platform ls` to verify that cordova-windows 5.0.0 was used
    - Build and run as both desktop and mobile app (using Visual Studio 2015)
    
    I do not think there is any need to update the automatic test suite. Please correct me
in case I am mistaken.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] ~~Added automated test coverage as appropriate for this change.~~


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brodybits/cordova-lib cb-12572

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #528
    
----
commit 391f23745be27633c6afadae227f275682699cf0
Author: Christopher J. Brody <brodybits@litehelpers.net>
Date:   2017-03-15T22:02:28Z

    CB-12572: (windows) pin cordova-windows 5.0.0

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message