cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From audreyso <>
Subject [GitHub] cordova-lib pull request #526: CB-11242 - Removed platform-specific code for...
Date Fri, 10 Mar 2017 23:06:52 GMT
GitHub user audreyso opened a pull request:

    CB-11242 - Removed platform-specific code for platforms w/ PlatformApi implemented

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    Removed platform-specific code for platforms w/ PlatformApi implemented (ios, android,
    Android testing files also updated.
    ### What testing has been done on this change?
    ### Checklist
    - [X] [Reported an issue]( in the JIRA
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull CB-11242

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #526
commit d0670a566a67bb8735577c3ba44f8daba060c196
Author: Audrey So <>
Date:   2017-03-03T18:28:50Z

    CB-11242 : removed parser and handler files for ios, windows, and android and added cordova
dir to android test in fixtures dir and removed uninstall android files because causing errors

commit a0b1f6b8ad88b7df941ffa6d953162f678a463ad
Author: Audrey So <>
Date:   2017-03-07T18:12:29Z

    CB-11242 - updated android install tests to use new files, fixed installed tests by updating
dummy plugin files, and updated android test files to use most recent files available

commit cc66c8656405e2329cedd186f8871de92fac8f8c
Author: Audrey So <>
Date:   2017-03-09T20:00:56Z

    CB-11242 : updated plugin.spec test to use original plugin version, use android test files,
and comment out test 002 - does not call prepare anymore and added node_modules dir

commit cfda10d14be34505bfa062534be5e8fd5776997e
Author: Audrey So <>
Date:   2017-03-10T21:32:49Z

    CB-11242 : added new browser test files to support PlatformApiPoly.spec.js tests

commit 8ba0df74df6765ec520111db3e3ed417591fde22
Author: Audrey So <>
Date:   2017-03-10T22:00:12Z

    CB-11242 : updated platformApi android test files and updated platforms.spec to use browser
instead of android


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message