cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From infil00p <>
Subject [GitHub] cordova-android pull request #367: CB-12524: Working around Android SDK upda...
Date Thu, 09 Mar 2017 18:41:57 GMT
GitHub user infil00p opened a pull request:

    CB-12524: Working around Android SDK update by finding Gradle in Android Studio itself,
if that fails, we look for a locally installed Gradle

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    This PR allows Cordova users to be able to build Android projects again using the platform
CLI tools.  
    ### What testing has been done on this change?
    Testing has been done on the build scripts to make sure things work, but testing on the
CLI integration still needs to be done.
    ### Checklist
    - [ x] [Reported an issue]( in the JIRA
    - [ x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull android_sdk_fixes

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #367
commit 78c5a54e5f255aab205ecbc72047b5cce9f18a66
Author: Joe Bowser <>
Date:   2017-03-06T23:03:32Z

    We're distributing a wrapper in the framework directory

commit 9469d11669fcf6ef4342954d46722144c9f36731
Author: Joe Bowser <>
Date:   2017-03-06T23:55:22Z

    CB-12524: Updating gradle to just grab the wrapper from the framework directory for building

commit 4502e3253783425eda5cff881e48f4d58de88e3e
Author: Joe Bowser <>
Date:   2017-03-07T22:29:02Z

    CB-12524: Create script needs to copy the wrapper from the framework directory to the
CordovaLib directory.  This means you can compile an AAR out of any of the projects if you

commit 8c01438e16ad1403e9eb54d1870bbc8371458343
Author: Joe Bowser <>
Date:   2017-03-09T02:09:49Z

    CB-12524: This now fetches the template from  inside of the Android Studio directory,
and falls back to a locally installed Gradle instance

commit a4fa4b79fc6a8ad8afe9249aa591c62e1742d666
Author: Bharath Hariharan <>
Date:   2017-02-23T19:13:10Z

    Updating version
     This closes #364

commit f3408169735e01817bdde113547ca40375529ebb
Author: Joe Bowser <>
Date:   2017-03-09T18:26:48Z

    CB-12524: Windows functionality for Gradle execution

commit 45e3c6983470d47628e8deba23ab41498638a8a9
Author: Joe Bowser <>
Date:   2017-03-09T18:32:07Z

    Accidentally committed temp files in Windows


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message