cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #296: CB-12571 - Podfile gets overwritten and some ...
Date Tue, 14 Mar 2017 22:19:55 GMT
GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-ios/pull/296

    CB-12571 - Podfile gets overwritten and some dependencies disappear.

    ### Platforms affected
    
    self
    
    ### What does this PR do?
    
    Fix adding of pods with non-alphanumeric characters in the name to Podfile
    
    ### What testing has been done on this change?
    
    Added unit tests
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-ios CB-12571

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/296.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #296
    
----
commit 514b3f1917a8079e3e24f0b2a4163478b437b309
Author: Shazron Abdullah <shazron@gmail.com>
Date:   2017-03-14T22:17:09Z

    CB-12571 - Podfile gets overwritten and some dependencies disappear.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message