cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-cli pull request #270: CB-11346 Remove known platforms check
Date Wed, 01 Mar 2017 00:20:04 GMT
GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-cli/pull/270

    CB-11346 Remove known platforms check

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    cli
    
    ### What does this PR do?
    Cleans up some messy code, removes checks for known platform names
    
    ### What testing has been done on this change?
    tests all still pass
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-cli CB-11346

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #270
    
----
commit 7022efefa9795864eff1204d2b49e8c6328463bb
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-02-28T23:08:58Z

    Remove un-used module and tests

commit a28e6c9cf5145a30f22ac5475d9d5cfaad7d840e
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-02-28T23:10:32Z

    Removed underscore dependency. Added my last name, I am not Oprah ...yet.

commit 23f530debcb6e938045c480f57473e172552f0dd
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-03-01T00:13:07Z

    Removed check for 'known' platforms, code cleanup, clarity, refactored

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message