cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cjpearson <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #257: CB-12953: (android) move management...
Date Tue, 21 Mar 2017 15:16:55 GMT
GitHub user cjpearson opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/257

    CB-12953: (android) move management of FileProvider out of the camera plugin

    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    Android
    
    ### What does this PR do?
    
    It allows multiple plugins to use the FileProvider. Each plugin that needs a provider
path can add it using the config-file element. Another plugin will update the AndroidManifest
and create the provider_paths file.
    
    I've created a stub for this other plugin at https://github.com/cjpearson/cordova-plugin-file-provider
so it builds correctly. I'm not sure if this other plugin should be a new plugin or added
to an existing plugin.
    
    ### What testing has been done on this change?
    
    Tested locally with cordova-android 6.1.2.
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjpearson/cordova-plugin-camera provider_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #257
    
----
commit 37f0a54dbdb1c16c019c6683f519278de0d2e584
Author: Connor Pearson <cpearson@b2wsoftware.com>
Date:   2017-03-21T14:04:09Z

    CB-12953: (android) move management of FileProvider out of the camera plugin

commit bfb150efea8297406f06c12a1e0631b4ffae91f8
Author: Connor Pearson <cpearson@b2wsoftware.com>
Date:   2017-03-21T15:10:00Z

    use github link

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message