cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblood <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #215: CB-12560: (android) fix null ...
Date Fri, 10 Mar 2017 00:37:00 GMT
GitHub user dblood opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/215

    CB-12560: (android) fix null pointer with callback when loading multiā€¦

    ### Platforms affected
    Android
    
    ### What does this PR do?
    When multiple urls are requested sequentially (such as a monitor script), the object reference
to callback could be nulled by another thread causing a NullPointerException.
    
    ### What testing has been done on this change?
    I have run the automated tests, and successfully ran the application without the crash.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dblood/cordova-plugin-inappbrowser CB-12560

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #215
    
----
commit fc08376ee1bcced9fd37912c7559a9abe0dc520f
Author: Douglas Blood <bloodd@ospri.co.nz>
Date:   2017-03-10T00:30:08Z

    CB-12560: (android) fix null pointer with callback when loading multiple urls

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message