cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <>
Subject [GitHub] cordova-plugin-screen-orientation pull request #14: Add manual tests
Date Mon, 20 Mar 2017 19:41:44 GMT
GitHub user filmaj opened a pull request:

    Add manual tests

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    Please review @purplecabbage and @maverickmishra.
    ### Platforms affected
    ### What does this PR do?
    Adds manul tests in the style of [cordova-plugin-test-framework's manual tests](
    ### What testing has been done on this change?
    Tested on an Android 7.1 emulator and on an iOS 10.2 simulator, using [cordova-mobile-spec's
`createmobilespec` helper](
    ### Checklist
    - [X] [Reported an issue]( in the JIRA
database: [CB-12588](
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull CB-12588

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14
commit f12721b35e8f48599d1698ead85eaf707b8532fa
Author: filmaj <>
Date:   2017-03-20T19:36:50Z

    CB-12588: add manual tests in cordova-plugin-test-framework style


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message