cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From romedius <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request #137: CB-12146 (android) Adding playAudioW...
Date Sat, 25 Mar 2017 01:41:30 GMT
GitHub user romedius opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/137

    CB-12146 (android) Adding playAudioWhenScreenIsLocked for Android

    When loosing focus of the app in android (onPause()) the audio playback is paused when
playAudioWhenScreenIsLocked is set to false.
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Adds the playAudioWhenScreenIsLocked flag to the Android version. This makes it possible
to selectively keep audios playing, when onPause is called.
    
    ### What testing has been done on this change?
    Manual testing on Android N
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/romedius/cordova-plugin-media CB-12146cordova-plugin-media

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
    
----
commit 36e4fdf22820f750d96774e0e254327aca062dec
Author: Romedius Weiss <romedius.weiss@gmail.com>
Date:   2017-03-24T17:54:26Z

    CB-12146 (android) Adding playAudioWhenScreenIsLocked for Android
    
    When loosing focus of the app in android (onPause()) the audio playback is paused if playAudioWhenScreenIsLocked
is set to false.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message