cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request #132: CB-12542 - Can't record to a wav fil...
Date Thu, 09 Mar 2017 20:46:59 GMT
GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/132

    CB-12542 - Can't record to a wav file

    Thanks to Leo Schubert for this patch (see JIRA issue).
    
    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    Change the file extension of the file being recorded to .m4a  (AAC)
    
    ### What testing has been done on this change?
    
    cordova-paramedic local test on iOS (flaky). I plan to let the CI run the device tests.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-plugin-media CB-12542

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #132
    
----
commit b77adb2fb8f0cf8fd72352959bbdc3b9b76e2791
Author: Shazron Abdullah <shazron@gmail.com>
Date:   2017-03-09T19:18:41Z

    CB-12542 - Can't record to a wav file
    
    Thanks to Leo Schubert (ls at 4js dot com) for this patch.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message