cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <>
Subject [GitHub] cordova-plugin-screen-orientation pull request #13: [windows] Fix failing te...
Date Sat, 11 Mar 2017 02:01:42 GMT
GitHub user purplecabbage opened a pull request:

    [windows] Fix failing tests, added Promise if it is not defined 8.1

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    ### What testing has been done on this change?
    ### Checklist
    - [ ] [Reported an issue]( in the JIRA
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull WindowsFailingTests

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
commit 837c17b4797ed134c3a699be2c5be552d1f61ec6
Author: Jesse MacFadyen <>
Date:   2017-03-11T01:59:50Z

    [windows] Fix failing tests, added Promise if it is not defined 8.1


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message