cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maverickmishra <...@git.apache.org>
Subject [GitHub] cordova-plugin-screen-orientation pull request #12: Follows spec w3 c
Date Thu, 09 Mar 2017 02:09:16 GMT
GitHub user maverickmishra opened a pull request:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/12

    Follows spec w3 c

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS, Android, Windows
    ### What does this PR do?
     The PR makes the plugin conform to exact W3C specs. screen.orientation.angle and screen.orientation.onchange
attributes implemented.
    
    ### What testing has been done on this change?
    Tested on android and iOS devices and also using unit tests.
    
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maverickmishra/cordova-plugin-screen-orientation FollowSpecW3C

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12
    
----
commit 6b07847d9aab5c18d49d59a9cf88f98bba67bcf0
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-02-22T19:34:21Z

    added missing tests, fixed indentation of js file

commit 60f639b5538a53ce056f14e2a70894247126b279
Author: maverickmishra <vishalmishra0907@gmail.com>
Date:   2017-03-09T01:45:24Z

    The plugin now follows W 3 specs ; tests for screen.orientation.onchange pending

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message