cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cnspaha <>
Subject [GitHub] cordova-plugin-screen-orientation pull request #11: CB-12543 (iOS) Set orien...
Date Mon, 06 Mar 2017 06:40:30 GMT
GitHub user cnspaha opened a pull request:

    CB-12543 (iOS) Set orientation on when locking the device

    ### Platforms affected
    ### What does this PR do?
    Instead of just locking the orientation, it also rotates to it. Mandatory for iOS.
    ### What testing has been done on this change?
    Manual testing on iOS 10, iPhone 6+.
    Run: "npm test"
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull setOrientationOnLock

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11
commit 7185add951fff8d405338af5ef812cb34c476315
Author: Pascal Häusler <>
Date:   2017-03-03T14:03:09Z

    Rotate to specified orientation when locked

commit 141dea7e6b28f3900e530dd7e2def21f762e807d
Author: Pascal Häusler <>
Date:   2017-03-06T06:19:56Z


commit fbe1c98d8c9389dabaef23b5c0b31b015ff87c3b
Author: Pascal Häusler <>
Date:   2017-03-06T06:26:54Z

    Update screenorientation.js to prevent jshint to fail test

commit 2ee910ecbcd2311d150e32dcdca0aa5d3482ca5f
Author: Pascal Häusler <>
Date:   2017-03-06T06:27:34Z

    Update CDVOrientationproxy.js to prevent jshint to fail test


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message