cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kerri Shotts <kerrisho...@gmail.com>
Subject Re: [DISCUSS] Plugin search is broken
Date Fri, 24 Mar 2017 18:01:40 GMT
Cool. Thanks! :-)

~ Kerri

> On Mar 24, 2017, at 12:52, Shazron <shazron@gmail.com> wrote:
> 
> Here:
> https://github.com/apache/cordova-docs/blob/a3589ce66336821f2fd714a1115125cfcfa9fd1b/www/static/plugins/app.js
> 
> On Fri, Mar 24, 2017 at 5:36 AM, Kerri Shotts <kerrishotts@gmail.com> wrote:
> 
>> +1 to moving off npmsearch.
>> 
>> While I’m thinking of it — where does the code for the plugin search live?
>> I found variations on it, but not sure I ever came across the canonical
>> version.
>> 
>> ~ Kerri
>> 
>>> On Mar 23, 2017, at 16:04, Shazron <shazron@apache.org> wrote:
>>> 
>>> I'm going to assume by lazy consensus that moving off npmsearch is a
>> 'go'.
>>> 
>>> Filed: https://issues.apache.org/jira/browse/CB-12602
>>> 
>>> Currently our plugin search works after I filed those two issues in their
>>> repo and they were was fixed, thus fixing our search.
>>> 
>>> On Sun, Mar 19, 2017 at 4:36 PM, Shazron <shazron@apache.org> wrote:
>>> 
>>>> Consequently, found another bug and filed: https://issues.apache.
>>>> org/jira/browse/CB-12585
>>>> 
>>>> On Sun, Mar 19, 2017 at 4:04 PM, Shazron <shazron@apache.org> wrote:
>>>> 
>>>>> I filed https://github.com/nodesource/npmsearch/issues/54 earlier and
>>>>> the dev fixed it right away, yay! So currently our search is working
>> again,
>>>>> but the original proposal stands regarding migration.
>>>>> 
>>>>> On Sun, Mar 19, 2017 at 1:50 PM, Shazron <shazron@apache.org> wrote:
>>>>> 
>>>>>> Ignore the last message ;)
>>>>>> 
>>>>>> This results in zero results.
>>>>>> http://npmsearch.com/query/?fields=name,keywords,license,des
>>>>>> cription,author,modified,homepage,version,rating&q=keywords:
>>>>>> %22ecosystem:cordova%22&sort=rating:desc
>>>>>> 
>>>>>> The same URL without the sort query param has results:
>>>>>> 
>>>>>> http://npmsearch.com/query/?fields=name,keywords,license,des
>>>>>> cription,author,modified,homepage,version,rating&q=keywords:
>>>>>> %22ecosystem:cordova%22
>>>>>> 
>>>>>> 
>>>>>> On Sun, Mar 19, 2017 at 1:44 PM, Shazron <shazron@apache.org>
wrote:
>>>>>> 
>>>>>>> I believe the original problem lies in npmsearch.com erroring
on a
>>>>>>> query param "sort":
>>>>>>> http://npmsearch.com/query/?sort=rating:desc&fields=name,key
>>>>>>> words,license,description,author,modified,homepage,version,r
>>>>>>> ating&sort=&q=keywords:%22ecosystem:cordova%22
>>>>>>> 
>>>>>>> The URL above is a query that we send to it. (a simple "sort="
>> results
>>>>>>> in the same error)
>>>>>>> 
>>>>>>> If "sort" is removed, it is fine:
>>>>>>> http://npmsearch.com/query/?fields=name,keywords,license,des
>>>>>>> cription,author,modified,homepage,version,rating&sort=&q=key
>>>>>>> words:%22ecosystem:cordova%22
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> On Sun, Mar 19, 2017 at 1:25 PM, Shazron <shazron@apache.org>
wrote:
>>>>>>> 
>>>>>>>> The impetus for this is, users are reporting [1][2][3][4]
that they
>>>>>>>> can't find plugins, and I don't think they know of a search
>> alternative.
>>>>>>>> 
>>>>>>>> In the near term, I think we should tweet how to search for
plugins
>>>>>>>> using npmjs.com
>>>>>>>> 
>>>>>>>> [1] https://twitter.com/edeortuzar/status/843310576101146625
>>>>>>>> [2] https://twitter.com/kumakumadev/status/843149557127155712
>>>>>>>> [3] https://twitter.com/quangv/status/842925319254360064
>>>>>>>> [4] https://twitter.com/skumarSDsoft/status/842677001433497600
>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>>>> On Sun, Mar 19, 2017 at 1:19 PM, Shazron <shazron@apache.org>
>> wrote:
>>>>>>>> 
>>>>>>>>> ### PROBLEM
>>>>>>>>> 
>>>>>>>>> Plugin search is broken.
>>>>>>>>> 
>>>>>>>>> ### DESCRIPTION
>>>>>>>>> 
>>>>>>>>> Page:
>>>>>>>>> http://cordova.apache.org/plugins/
>>>>>>>>> 
>>>>>>>>> JIRA:
>>>>>>>>> https://issues.apache.org/jira/browse/CB-12579
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> Q: How does the plugin search work?
>>>>>>>>> 
>>>>>>>>> A:
>>>>>>>>> Page Source: http://cordova.apache.org/plugins
>>>>>>>>> and the source (this specific line): http://svn.apache.org/v
>>>>>>>>> iewvc/cordova/site/public/plugins/index.html?view=markup#l117
>>>>>>>>> 
>>>>>>>>> which is added from here:
>>>>>>>>> https://github.com/apache/cordova-docs/blob/master/www/plugi
>>>>>>>>> ns/index.html
>>>>>>>>> 
>>>>>>>>> which is generated from this React code:
>>>>>>>>> https://github.com/apache/cordova-docs/blob/a3589ce66336821f
>>>>>>>>> 2fd714a1115125cfcfa9fd1b/www/static/plugins/app.js
>>>>>>>>> 
>>>>>>>>> Nothing shows up as errors in the Web Inspector, so it
is hard to
>>>>>>>>> track down.
>>>>>>>>> 
>>>>>>>>> ### MY PROPOSAL
>>>>>>>>> 
>>>>>>>>> The era of needing npmsearch.com to populate this page
is over. We
>>>>>>>>> could just redirect users to npmjs.com and add the
>>>>>>>>> "ecosystem:cordova" token (i.e https://www.npmjs.com/sea
>>>>>>>>> rch?q=ecosystem%3Acordova)
>>>>>>>>> 
>>>>>>>>> The alternative is to use npm's Registry API:
>>>>>>>>> https://github.com/npm/registry/commits/master/docs/
>> REGISTRY-API.md
>>>>>>>>> 
>>>>>>>>> The API was only documented earlier this year, if not
we would have
>>>>>>>>> used it.
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>> 
>> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message