cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...
Date Fri, 31 Mar 2017 17:34:20 GMT
Github user shazron commented on the issue:

    https://github.com/apache/cordova-lib/pull/534
  
    Looks like the AppVeyor failure is node 6 only, which is suspicious and probably a hiccup:
    ```
    1) HooksRunner fire method plugin hooks Test 011 : should filter hook scripts from plugin.xml
by platform
      Message:
        Expected Error: Hook failed with error code 1: C:\Users\appveyor\AppData\Local\Temp\1\e2e-test\hooks_test\project\hooks\before_build\hookScript02.bat
to be undefined.
      Stack:
        Error: Expected Error: Hook failed with error code 1: C:\Users\appveyor\AppData\Local\Temp\1\e2e-test\hooks_test\project\hooks\before_build\hookScript02.bat
to be undefined.
            at C:\projects\cordova-lib\cordova-lib\spec-cordova\HooksRunner.spec.js:406:33
            at _rejected (C:\projects\cordova-lib\cordova-lib\node_modules\q\q.js:797:24)
            at C:\projects\cordova-lib\cordova-lib\node_modules\q\q.js:823:30
            at Promise.when (C:\projects\cordova-lib\cordova-lib\node_modules\q\q.js:1035:31)
    ```
    
    Thanks to @stevengill for the review. Seems any changes to `cordova-lib/src/plugman/platforms/ios.js`
should be removed since in cordova@7 everything will be in the Platform API. I will close
this PR and send a new (trivial) one for the `cordova-common` changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message