cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...
Date Thu, 30 Mar 2017 10:16:55 GMT
GitHub user shazron reopened a pull request:

    https://github.com/apache/cordova-lib/pull/534

    CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode
project

    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    Support the "embed" attribute for the `<framework>` tag of plugin.xml to facilitate
installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for
the iOS platform
    
    ### What testing has been done on this change?
    
    Added unit tests to `cordova-lib\spec-plugman\platforms\ios,spec.js`
    
    ### Other notes
    
    Complementary PR: https://github.com/apache/cordova-ios/pull/299
    
    ### Checklist
    
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-XXXX"
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-lib CB-11233

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/534.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #534
    
----
commit c3f4dcfca6bdc8b23cf4f46d49aca7abec449cb6
Author: Shazron Abdullah <shazron@gmail.com>
Date:   2017-03-30T08:39:43Z

    CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode
project

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message