cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From audreyso <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...
Date Tue, 28 Mar 2017 17:33:06 GMT
Github user audreyso commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/521#discussion_r108485285
  
    --- Diff: cordova-lib/src/cordova/restore-util.js ---
    @@ -64,7 +64,25 @@ function installPlatformsFromConfigXML(platforms, opts) {
                 // Combining arrays and checking duplicates.
                 comboArray = pkgJsonPlatforms.slice();
             }
    +
             engines = cfg.getEngines(projectHome);
    +
    +        // TODO: CB-12592: Eventually refactor out to pacakge manager module.
    +        // If package.json doesn't exist, auto-create one.
    +        if (engines.length > 0 && !fs.existsSync(pkgJsonPath)) {
    --- End diff --
    
    Was able to remove the duplicated lines:
    ```    if(fs.existsSync(pkgJsonPath)) {
            pkgJson = require(pkgJsonPath);```
    
    But if you update restore-util from:
    ```} else if (engines.length > 0 && !fs.existsSync(pkgJsonPath)) {```
    to
    ```} else if (engines.length > 0 && pkgJson) {```
    there will be many failures... will look into them


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message