cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...
Date Fri, 24 Mar 2017 22:21:55 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/521#discussion_r108009704
  
    --- Diff: cordova-lib/src/cordova/restore-util.js ---
    @@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {
                 // Combining arrays and checking duplicates.
                 comboArray = pkgJsonPlatforms.slice();
             }
    +
             engines = cfg.getEngines(projectHome);
    +
    +        if(fs.existsSync(pkgJsonPath)) {
    +            pkgJson = require(pkgJsonPath);
    +
    +        // If package.json doesn't exist, auto-create one.
    +        } else if (engines.length > 0 && !fs.existsSync(pkgJsonPath)) {
    --- End diff --
    
    It would be better to change this from `if (engines.length > 0 && !fs.existsSync(pkgJsonPath))`
to `if (engines.length > 0 && pkgJson))` Since you already check for `pkgJsonPath`
and `require pkgjson` on lines 53-54, you don't have to do another `existsSync` operation
(which is expensive).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message