cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...
Date Fri, 24 Mar 2017 20:39:38 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/521#discussion_r107994895
  
    --- Diff: cordova-lib/src/cordova/restore-util.js ---
    @@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {
                 // Combining arrays and checking duplicates.
                 comboArray = pkgJsonPlatforms.slice();
             }
    +
             engines = cfg.getEngines(projectHome);
    +
    +        if(fs.existsSync(pkgJsonPath)) {
    +            pkgJson = require(pkgJsonPath);
    +        // TODO: Eventually refactor out to pacakge manager module.
    --- End diff --
    
    oo you can keep it. Would be good practice to include the issue number in the todo. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message