cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping
Date Fri, 24 Mar 2017 03:29:58 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/522#discussion_r107829266
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -255,13 +235,7 @@ function checkID(expectedIdAndVersion, pinfo) {
         if (!expectedIdAndVersion) return;
     
         var parsedSpec = pluginSpec.parse(expectedIdAndVersion);
    -
    -    if (parsedSpec.id != pinfo.id) {
    -        var alias = parsedSpec.scope ? null : pluginMappernto[parsedSpec.id] || pluginMapperotn[parsedSpec.id];
    --- End diff --
    
    for this section, can you get rid of lines 260-263 but keep line 262.
    
    It should look like 
    ```
     if (parsedSpec.id != pinfo.id) {
        throw new Error('Expected plugin to have ID "' + parsedSpec.id + '" but got "' + pinfo.id
+ '".');
    }
    ```
    
    That way, you can also undo your changes to cordova-lib/spec-plugman/fetch.spec.js. We
should keep those tests I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message