cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From infil00p <...@git.apache.org>
Subject [GitHub] cordova-android pull request #370: CB-12595: Fix Android Studio Detection (m...
Date Tue, 21 Mar 2017 23:15:13 GMT
GitHub user infil00p reopened a pull request:

    https://github.com/apache/cordova-android/pull/370

    CB-12595: Fix Android Studio Detection (may need refactoring)

    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Allows for the installation of multiple versions of Android Studio on a system without
breaking the Cordova Build.
    
    ### What testing has been done on this change?
    Tested it on local machine.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/infil00p/cordova-android CB-12595

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #370
    
----
commit 64ad1f386469e588ffb5da9acc616c016dfc9ee7
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-03-21T23:07:42Z

    CB-12595: Ugly code, but this should find an Android Studio installation and use the sweet
gradle center found inside

commit 89eb28c4ca264bbac3bfec26ea14fd5d14a54cc2
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-03-21T23:14:40Z

    CB-12595: Just because it generates the project doesn't mean it builds.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message