cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From duchuyctlk <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request #124: CB-10893: (android) Allow set...
Date Sun, 19 Mar 2017 18:34:04 GMT
Github user duchuyctlk commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r106814440
  
    --- Diff: src/android/SplashScreen.java ---
    @@ -313,6 +315,22 @@ public void run() {
                         splashDialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
    --- End diff --
    
    `splashDialog.getWindow()` is repeatedly used, so i think it could be extracted into a
variable to avoid multiple method calls.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message