cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CelsoSantos <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen issue #107: Browser platform brought closer to i...
Date Fri, 17 Mar 2017 16:43:30 GMT
Github user CelsoSantos commented on the issue:

    https://github.com/apache/cordova-plugin-splashscreen/pull/107
  
    Hello, @petermetz,
    
    Any chance I could request a small change to this PR? I've modified my plugin code locally
to get what I want and is really simple.
    
    Basically on line `localSplash.style.backgroundColor = bgColor;` we can only set a BG
color here.
    What I want is to have a more complex definition for the background.
    
    Example:
    ```
    ...
    localSplash.style.background = bgColor; //or change the name if this var to bg, maybe?
    ...
    ```
    
    Which means I can now have something like this on config.xml (notice the "complex" value):
    ```
    <preference name="SplashScreenBackgroundColor" value="linear-gradient(0deg,rgba(7,14,18,0.9),rgba(19,38,50,0.85)),
url('/assets/images/myimage.jpg') no-repeat top center fixed / cover"/>
    ```
    
    Any chance this could be introduced along with your PR instead of me having to go through
all the process to create a PR which is not nearly as complete as yours? (awesome work BTW)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message