cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-android pull request #367: CB-12524: Working around Android SDK upda...
Date Tue, 14 Mar 2017 22:27:47 GMT
Github user filmaj commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/367#discussion_r106043706
  
    --- Diff: bin/lib/check_reqs.js ---
    @@ -246,7 +273,11 @@ module.exports.check_android_target = function(originalError) {
         //   Google Inc.:Glass Development Kit Preview:20
         var valid_target = module.exports.get_target();
         var msg = 'Android SDK not found. Make sure that it is installed. If it is not at
the default location, set the ANDROID_HOME environment variable.';
    -    return tryCommand('android list targets --compact', msg)
    +    //   Changing "targets" to "target" is stupid and makes more code.  Thanks Google!
    +    var cmd = 'android list targets --compact';
    +    if(forgivingWhichSync('avdmanager').length > 0)
    +      cmd = 'avdmanager list target --compact';
    --- End diff --
    
    I just realized this but I think what we want here is to use `sdkmanager` and not `avdmanager`,
right @infil00p ? `avdmanager list targets` returns either AVD device definitions or existing
AVD IDs. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message