cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From leopatras <>
Subject [GitHub] cordova-plugin-media issue #131: CB-1254: (ios) Fix wav file recording, add ...
Date Sat, 11 Mar 2017 10:05:01 GMT
Github user leopatras commented on the issue:
    Hi, thank you for the tip !
    I created a “development” branch and did add the changes there (changed also the README
for ios). This seemed to work better.
    (I really can’t figure out how I destroyed my master branch, did a wrong rebasing probably).
    Re submitted !
    Kind Regards, Leo
    > On 11 Mar 2017, at 03:20, Shazron Abdullah <> wrote:
    > My suggestion is, to make it super easy, create a new branch off cordova-plugin-media
master (after getting the latest from Github). Then in this new branch, cherry-pick the 1
commit you made -- and re-submit the PR.
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub, or mute the thread.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message