cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From infil00p <...@git.apache.org>
Subject [GitHub] cordova-android pull request #367: CB-12524: Working around Android SDK upda...
Date Thu, 09 Mar 2017 19:54:49 GMT
Github user infil00p commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/367#discussion_r105255990
  
    --- Diff: bin/lib/check_reqs.js ---
    @@ -78,21 +79,46 @@ module.exports.check_ant = function() {
         });
     };
     
    +module.exports.get_gradle_wrapper = function() {
    +    var androidStudioPath;
    +    if(os.platform() == "darwin") {
    --- End diff --
    
    @dpogue Honestly, we're just installing the wrapper, so any will work.  I wanted to delete
https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GradleBuilder.js#L187
for a while, since it replaces everything with an old version of Gradle that just gets updated
anyway, but we might just have to keep it in and update it to the latest Gradle supported.
    
    FYI: My homebrew keeps fetching 2.2, and Android Studio 2.3 is packaged with 3.2 on my
Windows and Mac partitions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message