cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <>
Subject [GitHub] cordova-android pull request #367: CB-12524: Working around Android SDK upda...
Date Thu, 09 Mar 2017 19:32:06 GMT
Github user filmaj commented on a diff in the pull request:
    --- Diff: bin/lib/check_reqs.js ---
    @@ -78,21 +79,46 @@ module.exports.check_ant = function() {
    +module.exports.get_gradle_wrapper = function() {
    +    var androidStudioPath;
    +    if(os.platform() == "darwin") {
    --- End diff --
    K, based on the rest of the flow, it looks like for not-Mac and not-Windows, we're hoping
that `gradle` is on the PATH. Is that acceptable? I don't have an opinion either way but I
think it's worth posing the question.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message