Return-Path: <dev-return-66393-archive-asf-public=cust-asf.ponee.io@cordova.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B70CB200C32
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 23 Feb 2017 02:41:06 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id B59E6160B72; Thu, 23 Feb 2017 01:41:06 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0562E160B62
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 23 Feb 2017 02:41:05 +0100 (CET)
Received: (qmail 9580 invoked by uid 500); 23 Feb 2017 01:41:05 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 9569 invoked by uid 99); 23 Feb 2017 01:41:04 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2017 01:41:04 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 9AA93DFF0F; Thu, 23 Feb 2017 01:41:04 +0000 (UTC)
From: shazron <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
Message-ID: <git-pr-32-cordova-plugin-wkwebview-engine@git.apache.org>
Subject: [GitHub] cordova-plugin-wkwebview-engine pull request #32: CB-12497 - location.href l...
Content-Type: text/plain
Date: Thu, 23 Feb 2017 01:41:04 +0000 (UTC)
archived-at: Thu, 23 Feb 2017 01:41:06 -0000

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/32

    CB-12497 - location.href links are silently disallowed

    ### Platforms affected
    
    iOS WKWebView
    
    ### What does this PR do?
    
    Fixes the bug where javascript navigations were silently disallowed on this plugin.
    
    ### What testing has been done on this change?
    
    Manual testing on device - using a new default project with this plugin, and `<button onclick="location.href='tel:15551234'">LOCATION.HREF</button>`
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-plugin-wkwebview-engine CB-12497

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit 604c7754e4eda1e4c50434d11fb08c4de32837e5
Author: Shazron Abdullah <shazron@gmail.com>
Date:   2017-02-23T01:38:01Z

    CB-12497 - location.href links are silently disallowed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org