cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lazza <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...
Date Sun, 26 Feb 2017 19:21:53 GMT
GitHub user Lazza opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/77

    CB-10879: (android) Enable overlaysWebView on Android API 21+

    ### Platforms affected
    
    Android (API 21+).
    
    ### What does this PR do?
    
    This patch enables devices running Android API 21+ to have the status bar overlaying the
WebView, i.e. `StatusBar.overlaysWebView(true)`. It lets any Android version call `StatusBar.overlaysWebView(false)`
to disable the overlay, which is actually the default behavior on that platform.
    
    ### What testing has been done on this change?
    
    It has been tested on emulators running several android versions, both before and after
API 21.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Lazza/cordova-plugin-statusbar patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit de4c0efa3a763807f9fbbf128ac165d2a43eb538
Author: Andrea Lazzarotto <andrea.lazzarotto@gmail.com>
Date:   2017-02-26T19:11:07Z

    Enable overlaysWebView on Android API 21+
    
    This patch enables devices running Android API 21+ to have the status bar overlaying the
WebView, i.e. `StatusBar.overlaysWebView(true)`. It lets any Android version call `StatusBar.overlaysWebView(false)`
to disable the overlay, which is actually the default behavior on that platform.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message