cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ngjaying <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request #76: CB-12188 Status Bar is not changi...
Date Thu, 09 Feb 2017 00:43:06 GMT
GitHub user ngjaying opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/76

    CB-12188 Status Bar is not changing in some specific android phone (Red MI 3s Prime)

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Allow some 3rd party Android OS like MUI  to change status bar color. In such OS, the
Window class is inherited. So window.getClass().getDeclaredMethod("setStatusBarColor", int.class)
will return null, because "setStatusBarColor" is declared in parent class. 
    Change to window.getClass().getMethod("setStatusBarColor", int.class) will do the trick.
And the change also make sure the same behavior as window.setStatusBarColor(colorPref);
    
    ### What testing has been done on this change?
    Tested on MI 5 device
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ngjaying/cordova-plugin-statusbar master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #76
    
----
commit dcabcf6f5e0aa009016b39c96d77cb894e4a6ce5
Author: olln3 <johnnyyellow@gmail.com>
Date:   2017-02-09T00:35:45Z

    CB-12188 Status Bar is not changing in some specific android phone (Red MI 3s Prime)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message