cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matrosov-nikita <...@git.apache.org>
Subject [GitHub] cordova-android pull request #362: CB-12453: Remove unnecessary double quote...
Date Wed, 22 Feb 2017 14:19:23 GMT
GitHub user matrosov-nikita opened a pull request:

    https://github.com/apache/cordova-android/pull/362

    CB-12453: Remove unnecessary double quotes from .bat files which are the causes of crash
if project path contains spaces

    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    self
    
    ### What does this PR do?
    This PR fixes bug with crash if project path contains spaces
    
    ### What testing has been done on this change?
    Current auto-tests don't work if project path contains spaces, this PR fixes it
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosov-nikita/cordova-android allow-spaces-in-project-path

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #362
    
----
commit 7f2f6943459c8bd806b8d6aea77e4b447260ecb8
Author: Nikita Matrosov <v-nimatr@microsoft.com>
Date:   2017-02-16T14:36:23Z

    CB-12453: Remove unnecessary double quotes from .bat files which are the causes of crash
if project path contains spaces

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message