cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wlmzfx <...@git.apache.org>
Subject [GitHub] cordova-android pull request #356: The CoreAndroid's loadUrl method should l...
Date Fri, 03 Feb 2017 10:18:50 GMT
GitHub user wlmzfx opened a pull request:

    https://github.com/apache/cordova-android/pull/356

    The CoreAndroid's loadUrl method should load web pages in the UI thread

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Upate CoreAndroid's loadUrl method to load web pages in the UI thread
    
    ### What testing has been done on this change?
    Built and run the generated application, calling {color:red}navigator.app.loadUrl('http://domain.com',
{ "clearHistory": true}){color} , verify that there is not more errors and navigation can
be made successfully.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-12421: The CoreAndroid's loadUrl method should
load web pages in the UI thread"
    - [x] Added automated test coverage as appropriate for this change. (don't know how?)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wlmzfx/cordova-android app-load-url

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #356
    
----
commit eaeaf94f2f7b986bc2210fa65b95c2b3f55f157a
Author: Pu Wang <pu.wang@igt.com>
Date:   2017-02-03T09:47:32Z

    The CoreAndroid's loadUrl method will load web pages in the UI thread

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message