cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rubenstolk <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request #30: Allow XHR to file:// and a...
Date Thu, 02 Feb 2017 20:11:47 GMT
GitHub user rubenstolk opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30

    Allow XHR to file:// and allow local file (upload) handling

    I know this PR won't be merged but I wanted to submit it anyways for people who face the
same issues and want a solution that works for at least iOS 9 + 10.
    
    (This PR replaces an earlier experimental version at https://github.com/apache/cordova-plugin-wkwebview-engine/pull/26)
    
    Until there is a better solution to setting this property, this solves the XHR and local
file api issues.
    This issue is described further in https://bugs.webkit.org/show_bug.cgi?id=154916.
    
    ### Platforms affected
    - [x] iOS
    
    ### What does this PR do?
    - [x] Prevents "Security DOM 18 error" while manipulating files, such as handling file
uploads
    - [x] Prevents "NetworkError (DOM Exception 19):  A network error occurred." while loading
files through XHR from `file://`
    
    ### What testing has been done on this change?
    - [x] XHR and file handling (incl. reading using File api etc)
    - [x] Test on iOS 10
    - [x] Test on iOS 9

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/safetychanger/cordova-plugin-wkwebview-engine allow-file-access

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit 69b9787e5d847e9e8263a56963b8e4a72e8911a9
Author: Ruben Stolk <ruben.stolk@changer.nl>
Date:   2017-02-02T20:08:13Z

    Allow XHR to file:// and allow local file (upload) handling

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message