cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khawkins <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #289: CB-12384 ios: Add Cocoa Touch Framework targe...
Date Wed, 15 Feb 2017 19:07:06 GMT
GitHub user khawkins opened a pull request:

    https://github.com/apache/cordova-ios/pull/289

    CB-12384 ios: Add Cocoa Touch Framework target for CordovaLib functionality

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    Adds a Cocoa Touch Framework target to the CordovaLib project, in anticipation of support
for tools like Carthage (parent issue: [CB-12050](https://issues.apache.org/jira/browse/CB-12050)).
    
    ### What testing has been done on this change?
    
    In the cordova-ios Xcode workspace under tests/, An app target was added to consume the
framework target as part of the unit testing process.  All tests are verified as passing in
both targets.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khawkins/cordova-ios CB-12384

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #289
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message