cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matrosov-nikita <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #288: CB-12402 CB-12206 Properly encode app name to...
Date Mon, 13 Feb 2017 13:05:04 GMT
GitHub user matrosov-nikita opened a pull request:

    https://github.com/apache/cordova-ios/pull/288

    CB-12402 CB-12206 Properly encode app name to generate XML files

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    self
    
    ### What does this PR do?
    The build fails due to corrupted xml files at platforms/ios/<APPNAME>.xcworkspace/**.
This PR adds logic to encode app name. 
    
    ### What testing has been done on this change?
    Auto-test
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosov-nikita/cordova-ios xml-encoded-xcworkspace

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #288
    
----
commit 9b7efc9bb2af115cd5efb5eae79cfdad6c54b0d2
Author: Nikita Matrosov <v-nimatr@microsoft.com>
Date:   2017-02-13T13:01:02Z

    CB-12402 CB-12206 Properly encode app name to generate XML files
    
    The build fails due to corrupted xml files at platforms/ios/<APPNAME>.xcworkspace/**

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message