cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <>
Subject [GitHub] cordova-plugin-media pull request #127: CB-12434 (Android) fix Stoping a Pau...
Date Thu, 09 Feb 2017 22:57:09 GMT
GitHub user jcesarmobile opened a pull request:

    CB-12434 (Android) fix Stoping a Paused Recording throws exception

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    When you pause the recording and the stop it, the audio is added twice to the tempFiles
list, so when it's moved it's moved twice, but the second time it no longer exits. This PR
checks if the file is already on the list and doesn't add it if it's already there.
    ### What testing has been done on this change?
    Manual testing on Android 5 and 6 phones
    ### Checklist
    - [X] [Reported an issue]( in the JIRA
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull CB-12434

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
commit ffeb17feb2d4a6493a3395d4db09f7e54144b6ae
Author: Julio C├ęsar <>
Date:   2017-02-09T22:49:10Z

    CB-12434 (Android) fix Stoping a Paused Recording throws exception


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message