cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping
Date Tue, 28 Feb 2017 02:18:45 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/522#discussion_r103362278
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -342,13 +322,6 @@ function copyPlugin(pinfo, plugins_dir, link) {
         var dest = path.join(plugins_dir, pinfo.id);
         var altDest;
     
    -    //check if alternative id already exists in plugins directory
    -    if(pluginMapperotn[pinfo.id]) {
    -        altDest = path.join(plugins_dir, pluginMapperotn[pinfo.id]);
    -    } else if(pluginMappernto[pinfo.id]) {
    -        altDest = path.join(plugins_dir, pluginMappernto[pinfo.id]);
    -    }
    -
         if(fs.existsSync(altDest)) {
    --- End diff --
    
    I think altDest doesn't need to exist anymore


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message