cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request #32: CB-12497 - location.href l...
Date Fri, 24 Feb 2017 11:11:18 GMT
GitHub user shazron reopened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/32

    CB-12497 - location.href links are silently disallowed

    ### Platforms affected
    
    iOS WKWebView
    
    ### What does this PR do?
    
    Fixes the bug where javascript navigations were silently disallowed on this plugin.
    
    ### What testing has been done on this change?
    
    Manual testing on device - using a new default project with this plugin, and `<button
onclick="location.href='tel:15551234'">LOCATION.HREF</button>`
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-plugin-wkwebview-engine CB-12497

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit 604c7754e4eda1e4c50434d11fb08c4de32837e5
Author: Shazron Abdullah <shazron@gmail.com>
Date:   2017-02-23T01:38:01Z

    CB-12497 - location.href links are silently disallowed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message