cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine issue #20: Fix handling of tel and mailto sc...
Date Thu, 23 Feb 2017 01:29:26 GMT
Github user shazron commented on the issue:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20
  
    Ok, for location.href (say in a button tag onclick handler), it's definitely a bug when
using wkwebview-engine (UIWebView is fine). For the CDVIntentAndNavigationFilter, we are passing
back the navigationType, which is of type [WKNavigationType](https://developer.apple.com/reference/webkit/wknavigationtype).
It looks like the enumeration is the same as [UIWebViewNavigationType](https://developer.apple.com/reference/uikit/uiwebviewnavigationtype)
(which the filter uses for its logic), but not quite. 
    
    All enum integral values are the same for the two enumerations, except for [WKNavigationTypeOther](https://developer.apple.com/reference/webkit/wknavigationtype/1401930-other)
which is set to -1 explicitly, while [UIWebViewNavigationTypeOther](https://developer.apple.com/reference/uikit/uiwebviewnavigationtype/1617934-other)
is 5.
    
    I'll file an issue to fix this by coercing the value explicitly to UIWebViewNavigationTypeOther
when a WKNavigationTypeOther is encountered, before passing it off to the filter.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message