cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts issue #146: CB-12326
Date Thu, 23 Feb 2017 01:11:25 GMT
Github user filmaj commented on the issue:

    https://github.com/apache/cordova-plugin-contacts/pull/146
  
    It _does_ look like [iOS returns label information](https://github.com/apache/cordova-plugin-contacts/blob/master/src/ios/CDVContact.h#L92)
in contacts, so there is precedent to enhance Android to do that as well.
    
    > Adding the missing "LABEL" CommonDataKinds columns to the ContactAccessorSdk5 to
fix the app crash issue.
    
    @mad-nuts can you elaborate on what 'the app crash issue' is? I'm curious what scenario
caused a crash.
    
    @infil00p if you have a moment, take a look at the generic try/catch flow this pull request
introduces and let us know if you have any comments on that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message