cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ghenry22 <...@git.apache.org>
Subject [GitHub] cordova-plugin-media issue #129: (android) Fix NullPointerException in Audio...
Date Thu, 23 Feb 2017 00:35:10 GMT
Github user ghenry22 commented on the issue:

    https://github.com/apache/cordova-plugin-media/pull/129
  
    @TommiKetola #122 should catch most scenarios that would cause this one to occur.  However,
there is no validation that a value is passed in to the method that this PR patches either
so there is always the change that we are comparing a NULL to something.
    
    I still think this patch should be included as well so that basic data validation is performed.
    
    @shazron - I have been testing this PR out over the last few days in my own apps and have
had no issues.  This could be merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message