cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugins pull request #28: CB-12443 CB-10959 (ios) include path and f...
Date Wed, 22 Feb 2017 21:18:39 GMT
Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-plugins/pull/28#discussion_r102574949
  
    --- Diff: local-webserver/src/ios/CDVLocalWebServer.m ---
    @@ -52,6 +53,12 @@ - (void) pluginInitialize {
         if (startPageUrl != nil) {
             if ([[startPageUrl scheme] isEqualToString:@"http"] && [[startPageUrl
host] isEqualToString:@"localhost"]) {
                 port = [[startPageUrl port] unsignedIntegerValue];
    +            if ([startPageUrl path].length > 1) {
    +                indexPage = [[startPageUrl path] substringFromIndex:1];
    +            }
    +            if ([startPageUrl fragment].length > 1) {
    --- End diff --
    
    Similarly here. Fragments that are 1 char in length will not be considered as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message