cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-plugin-device issue #58: CB-12199: (android) Add SDK version propert...
Date Wed, 22 Feb 2017 07:12:09 GMT
Github user stevengill commented on the issue:

    https://github.com/apache/cordova-plugin-device/pull/58
  
    hey @yamane-dsys!
    
    Your PR is in great shape. I appreciate you adding tests too! 
    
    Unfortunately, I don't think I can accept this PR. We only add new properties to device
if it can be implemented across all of our platforms. 
    
    I'm curious what your use-case for this is? 
    
    You should think about creating a plugin for this specific use-case yourself. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message