cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-lib issue #519: CB-11346 - Remove known platforms check for Platform...
Date Wed, 22 Feb 2017 00:32:55 GMT
Github user purplecabbage commented on the issue:

    https://github.com/apache/cordova-lib/pull/519
  
    I've started a discuss thread on this subject.
    https://github.com/cordova/cordova-discuss/issues/64
    
    
    @purplecabbage
    risingj.com
    
    On Tue, Feb 21, 2017 at 4:20 PM, Jesse <purplecabbage@gmail.com> wrote:
    
    > We should ultimately just be checking that there is a valid platformAPI,
    > and if so, use it, otherwise fail.
    > ( super simplification )
    >
    >
    > @purplecabbage
    > risingj.com
    >
    > On Tue, Feb 21, 2017 at 4:19 PM, Jesse <purplecabbage@gmail.com> wrote:
    >
    >> Yeah, it's deep. If a platform does not have a known name, there will be
    >> issues currently.
    >> The only way right now is to fork a blessed platform, but there is no way
    >> to easily create your own with a generic name.
    >>
    >>
    >>
    >> @purplecabbage
    >> risingj.com
    >>
    >> On Tue, Feb 21, 2017 at 4:16 PM, Shazron Abdullah <
    >> notifications@github.com> wrote:
    >>
    >>> The src/platforms/platforms.js file touches almost all commands,
    >>> particularly the use of the getPlatformAPI call, so removing this is
    >>> tricky -- but at least there is only one API call to abstract away.
    >>>
    >>> —
    >>> You are receiving this because you were mentioned.
    >>> Reply to this email directly, view it on GitHub
    >>> <https://github.com/apache/cordova-lib/pull/519#issuecomment-281525835>,
    >>> or mute the thread
    >>> <https://github.com/notifications/unsubscribe-auth/AAC0NikI4Tm7AIyhXZB6Ke6Mt6i0-tDFks5re35ngaJpZM4MGyTP>
    >>> .
    >>>
    >>
    >>
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message