cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-lib issue #519: CB-11346 - Remove known platforms check for Platform...
Date Tue, 21 Feb 2017 23:02:41 GMT
Github user shazron commented on the issue:

    https://github.com/apache/cordova-lib/pull/519
  
    re: https://issues.apache.org/jira/browse/CB-11346?focusedCommentId=15875577&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15875577
    
    Looks like there is more to it than the patch. The error occurs here: https://github.com/apache/cordova-lib/blob/a9605411ab007d700849c971043f0c211c06100c/cordova-lib/src/cordova/platform.js#L389
    
    All three conditions have to be satisfied:
    1. version (from package.json)
    2. platform name (from package.json name, has to be in the form of cordova-XXXX where
XXX is the actual platform name)
    3. platform name exists in platformConfig.json file
    
    We would have to remove checks 2 and 3, but not sure of the impact since platformConfig.json
contains information that is probably needed elsewhere (ideally it would exist in the platform
itself!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message