Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: stevengill <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-510-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-510-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...
Content-Type: text/plain
Message-Id: <20170111023017.DB5CDDFEEF@git1-us-west.apache.org>
Date: Wed, 11 Jan 2017 02:30:17 +0000 (UTC)
archived-at: Wed, 11 Jan 2017 02:30:24 -0000

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/510#discussion_r95501387
  
    --- Diff: cordova-lib/spec-plugman/create.spec.js ---
    @@ -35,46 +35,42 @@ describe( 'create plugin', function() {
             existsSync,
             mkdir,
             writeFileSync;
    -    function createPromise( f ) {
    -        f.then( function() { done = true; }, function(err) { done = err; } );
    -    }
    +
         beforeEach( function() {
    -        existsSync = spyOn( fs, 'existsSync' ).andReturn( false );
    -        mkdir = spyOn( shell, 'mkdir' ).andReturn( true );
    +        existsSync = spyOn( fs, 'existsSync' ).and.returnValue( false );
    +        mkdir = spyOn( shell, 'mkdir' ).and.returnValue( true );
             writeFileSync = spyOn( fs, 'writeFileSync' );
             done = false;
         });
     
    -    it( 'should be successful', function() {
    -        runs(function() {
    -            createPromise( create( 'name', 'org.plugin.id', '0.0.0', '.', [] ) );
    -        });
    -        waitsFor(function() { return done; }, 'create promise never resolved', 500);
    -        runs(function() {
    -            expect( done ).toBe( true );
    -            expect( writeFileSync.calls.length ).toEqual( 2 );
    +    it( 'Test 002 : should be successful', function(done) {
    +        create('name', 'org.plugin.id', '0.0.0', '.', [])
    +        .then(function(result) {
    +            expect( writeFileSync.calls.count() ).toEqual( 2 );
    +            done();
    +        }).fail(function err(errMsg) {
    +            done();
    --- End diff --
    
    maybe add a expect errMsg to be undefined here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org